[codex] test: include Arduino header in LPC sketches#763
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughSix LPC platform test sketches under ChangesLPC Platform Test Fixture Header Includes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds explicit
#include <Arduino.h>lines to the LPC.inofixtures undertests/platform.Why
The LPC build currently preprocesses sketches before the LPC8xx Arduino core include roots are available to the scanner. That means generated
.ino.cppfiles can missArduino.h, leaving fixture code unable to resolve Arduino symbols such aspinMode,digitalWrite,delay,HIGH,LOW, andOUTPUT.Making the fixtures include
Arduino.hdirectly keeps the tests independent of scanner-side header injection and unblocks the LPC board CI failures.Validation
git diff --checkArduino.hSummary by CodeRabbit