Skip to content

[codex] test: include Arduino header in LPC sketches#763

Merged
zackees merged 1 commit into
mainfrom
codex/lpc-ino-arduino-include
Jun 22, 2026
Merged

[codex] test: include Arduino header in LPC sketches#763
zackees merged 1 commit into
mainfrom
codex/lpc-ino-arduino-include

Conversation

@zackees

@zackees zackees commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds explicit #include <Arduino.h> lines to the LPC .ino fixtures under tests/platform.

Why

The LPC build currently preprocesses sketches before the LPC8xx Arduino core include roots are available to the scanner. That means generated .ino.cpp files can miss Arduino.h, leaving fixture code unable to resolve Arduino symbols such as pinMode, digitalWrite, delay, HIGH, LOW, and OUTPUT.

Making the fixtures include Arduino.h directly keeps the tests independent of scanner-side header injection and unblocks the LPC board CI failures.

Validation

  • git diff --check
  • Verified all six LPC sketch fixtures include Arduino.h

Summary by CodeRabbit

  • Tests
    • Resolved compilation failures across multiple platform test fixtures by ensuring required core library dependencies are properly included in test sketches.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 43acfc36-be44-4cfc-a38c-5e5774611134

📥 Commits

Reviewing files that changed from the base of the PR and between 7566337 and 58bb574.

📒 Files selected for processing (6)
  • tests/platform/lpc804/lpc804.ino
  • tests/platform/lpc845/lpc845.ino
  • tests/platform/lpc845_build_flags/src/main.ino
  • tests/platform/lpc845brk/lpc845brk.ino
  • tests/platform/lpcxpresso804/lpcxpresso804.ino
  • tests/platform/lpcxpresso845max/lpcxpresso845max.ino

📝 Walkthrough

Walkthrough

Six LPC platform test sketches under tests/platform/ receive #include <Arduino.h> so that Arduino APIs used in those fixtures are available at compile time. The lpc845brk sketch additionally gains empty setup() and loop() stub functions.

Changes

LPC Platform Test Fixture Header Includes

Layer / File(s) Summary
Add Arduino.h include to all LPC platform sketches
tests/platform/lpc804/lpc804.ino, tests/platform/lpc845/lpc845.ino, tests/platform/lpc845_build_flags/src/main.ino, tests/platform/lpc845brk/lpc845brk.ino, tests/platform/lpcxpresso804/lpcxpresso804.ino, tests/platform/lpcxpresso845max/lpcxpresso845max.ino
All six sketches gain #include <Arduino.h>; lpc845brk.ino also adds empty setup() and loop() function stubs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 Hop hop, a header appears,
Six sketches now compile without tears.
Arduino.h included with care,
Setup and loop hang fresh in the air —
The bunny says: "Compile, no fears!" 🌟

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/lpc-ino-arduino-include

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 9db9bc4 into main Jun 22, 2026
84 of 91 checks passed
@zackees zackees deleted the codex/lpc-ino-arduino-include branch June 22, 2026 19:33
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant